Add a workflow for CI #1695
Merged
Add a workflow for CI #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that the CI fail because the build fail (a issue on npm that I am not sure to be able to debug). |
12 tasks
sgoggins
reviewed
Apr 5, 2022
| @@ -0,0 +1,43 @@ | |||
| name: Build Docker images | |||
There was a problem hiding this comment.
@mscherer : The Docker build in the test is failing. Which may mean something or it may not.
The command '/bin/sh -c npm run build' returned a non-zero code: 1
```
It looks like its being built with React? I know we previously were using NPM, setting the version to the latest of 12.22.x ..
There was a problem hiding this comment.
@mscherer : Maybe I should've seen you already noticed that.
There was a problem hiding this comment.
OK... I think I see what is happening.
|
I fixed a bug on the naming of the container, and I ignore the frontend for now |
mscherer
force-pushed
the
add_ci
branch
2 times, most recently
from
1922aa7
to
6cd5f03
Compare
The workflow try to build the docker image on PR, and push a image on each commit, and stable version when there is a release Signed-off-by: Michael Scherer <misc@redhat.com> Ignore the frontend for now
sgoggins
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow try to build the docker image on PR, and push
a image on each commit, and stable version when there is a release
Signed-off-by: Michael Scherer misc@redhat.com