Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving issue 1696 #1797

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Resolving issue 1696 #1797

merged 5 commits into from
Jun 8, 2022

Conversation

Preshh0
Copy link
Contributor

@Preshh0 Preshh0 commented Apr 21, 2022

Resolving issue 1696
Fixed a welcome guide for newcomers in the getting started dir.
In this PR:

  • I wrote out a more detailed onboarding process for newcomers.
  • Added images for better understanding
  • Correctly referenced the issue this PR is supposed to resolve.

… users can find their way around.

Signed-off-by: Preshh0 <uniquep201@gmail.com>
@Preshh0 Preshh0 requested a review from sgoggins as a code owner April 21, 2022 15:36
…bsequent commands can run without errors.

Signed-off-by: Preshh0 <uniquep201@gmail.com>
@sgoggins
Copy link
Member

@Preshh0 : It looks like you've committed cloned repositories here: [workers/facade_worker/augur_facade/](https://github.com/chaoss/augur/pull/1797/files#diff-5f4378d21bfc35284b8ded339112675299ed0738e7dec1eae541b123e58eb480) ... Those cloned repos from our test repositories should not be committed to Augur source code.

Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove directory: workers/facade_worker/augur_facade/

@Preshh0
Copy link
Contributor Author

Preshh0 commented Apr 22, 2022

On it!

…nning a virtual environment for ubuntu would find it useful.

Signed-off-by: Preshh0 <uniquep201@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants