-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Schema Script and Addressing GH API Timeout. #1855
Conversation
Signed-off-by: Sean Goggins <outdoors@acm.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in worker_git_integration.py will not fix anything related to handing out new keys to workers. It will simply not make the first key used by a worker random, whereas before the changes the first key used was the key in the config so we don't use up all stored keys first. I would not recommend doing this, because we should use the key defined in the config first.
If there is an issue with handing out new keys to workers, the update_gh_rate_limit method in worker_git_integration.py would need to be looked at.
@ABrain7710 : The key in the config is no greater or lesser than the other keys. The issue right now is that in practice it is not rotating through the available keys. |
I understand they have the same number of requests, but we should use the key in the config first, because more people are likely to be using the stored keys at the same time, so we don't want to run those out first, we would rather run the one in the config first since it isn't shared. |
@ABrain7710 : If there's only the one in the config, its going to generate a random number of 1, and only hit that key. Everything still works if there's only the API key in the config. In practice the ones in the table are isolated to the organization running the instance. So all the keys have the same "value". |
@ABrain7710 : Right now, its simply not getting to all the keys before it goes kaput. In practice. |
Signed-off-by: Sean Goggins <outdoors@acm.org>
Pull Request Template