Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[raw/confluence] Remove credentials from raw items #1054

Merged
merged 1 commit into from
May 24, 2022

Conversation

zhquan
Copy link
Member

@zhquan zhquan commented May 20, 2022

This code redefines the method _fix_item for the confluence raw
data in order to remove credentials that may appear in the origin,
tag and data.content_url fields.

This change is needed to prevent storing the credentials in the
raw index.

Signed-off-by: Quan Zhou quan@bitergia.com

@coveralls
Copy link

coveralls commented May 20, 2022

Pull Request Test Coverage Report for Build 2379729703

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 81.91%

Totals Coverage Status
Change from base Build 2379714314: 0.07%
Covered Lines: 8766
Relevant Lines: 10702

💛 - Coveralls

@jjmerchante
Copy link
Contributor

LGTM

@zhquan zhquan force-pushed the anonymize_confluence branch 5 times, most recently from b95e1da to aca0a9a Compare May 23, 2022 16:48
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please, check my changes to the changelog entry.

releases/unreleased/remove-confluence-credentials.yml Outdated Show resolved Hide resolved
releases/unreleased/remove-confluence-credentials.yml Outdated Show resolved Hide resolved
releases/unreleased/remove-confluence-credentials.yml Outdated Show resolved Hide resolved
This code redefines the method _fix_item for the confluence raw
data in order to remove credentials that may appear in the
`origin`, `tag`, and `data.content_url` fields.

This change is needed to prevent storing the credentials in the
raw index.

Test added accordingly.

Signed-off-by: Quan Zhou <quan@bitergia.com>
@zhquan zhquan closed this in b66c00b May 24, 2022
@zhquan zhquan merged commit b66c00b into chaoss:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants