Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in event diversity #373

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix typos in event diversity #373

merged 1 commit into from
Oct 6, 2021

Conversation

eyehwan
Copy link
Member

@eyehwan eyehwan commented Jul 25, 2021

fix typos in event diversity metrics

Signed-off-by: Yehui Wang <yehui.wang.mdh@gmail.com>
Copy link
Contributor

@Nebrethar Nebrethar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eyehwan! Looks good to me

@wilcovian
Copy link

@Nebrethar : AI to update and fix. We are merging. Some of the edits are to split them apart.

@Nebrethar
Copy link
Contributor

We are happy to accept and merge this PR. 😁 Thanks for your contribution to the upcoming release.

Side Note: In the future, please create a new PR for each metric you want to update. That way we can improve them atomically.

@eyehwan Are you OK with being listed as a contributor on each of these metrics?

@Nebrethar Nebrethar merged commit 14fea01 into chaoss:main Oct 6, 2021
@eyehwan
Copy link
Member Author

eyehwan commented Oct 8, 2021

@eyehwan Are you OK with being listed as a contributor on each of these metrics?

Sure, I am happy to be part of it.

Nebrethar added a commit that referenced this pull request Oct 9, 2021
Signed-off-by: Matt Cantu Snell <msnell@unomaha.edu>
@Nebrethar
Copy link
Contributor

Attribution Commit: 42f886c

The situation raises a larger question of how we can add contributors to older metrics without a contributor list.
I opened chaoss/community#290 To try and solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants