-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scale_statefulset activity #73
add scale_statefulset activity #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just lacks a changelog entry :)
Looks good, is this replacing one of the oldest PRs? if so, could you close the ones it supersedes please? |
Sorry that's my first PRs. I'm on it |
I cut #68 in two different PRs : 68 and 73. But they both do something. |
04c2ade
to
b8fc4ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 80.05% 80.26% +0.21%
==========================================
Files 4 5 +1
Lines 361 375 +14
==========================================
+ Hits 289 301 +12
- Misses 72 74 +2
Continue to review full report at Codecov.
|
b8fc4ba
to
a2eb143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a2eb143
to
fffa570
Compare
did you merge commit or rebase from master? It's surprising to see this commit here 0829553 |
I feel the same. |
Oh I see. Don't worry, I'm not a git guru either :) To merge upstream into your master (or actually even directly to your branch).
The idea is that you configure upstream to point to the master from this repository. Then you pull and rebase directly from upstream master into your branch (without going through your local master). |
Signed-off-by: Thomas DEVILLE-DUC <thomas.deville-duc-prestataire@laposte.fr>
fffa570
to
7998095
Compare
With your help, i think i manage |
now, let's pull rebase the next PR :) |
Signed-off-by: Thomas DEVILLE-DUC thomas.deville-duc-prestataire@laposte.fr