Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

river: init #153

Merged
merged 1 commit into from
Jun 8, 2023
Merged

river: init #153

merged 1 commit into from
Jun 8, 2023

Conversation

rodrgz
Copy link
Contributor

@rodrgz rodrgz commented Jun 8, 2023

🐟 What?

  1. Added a new package;

🎣 Why?

  • (1) This new package is interesting to myself;

🍥 Pending

  • Complain with linter;
  • Remove some temporary fix;
  • Publishing to news' channel.

🐳 Extras

  • I like chocolate cake.

@rodrgz rodrgz requested a review from a team as a code owner June 8, 2023 02:48
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Thank you for contributing to nyx! Please run nix fmt on your code before submitting a pull request. Afterwards, please force push your changes.

@PedroHLC
Copy link
Member

PedroHLC commented Jun 8, 2023

Can you rebase and apply linter suggestions? (nix fmt and statix)

PedroHLC
PedroHLC approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@PedroHLC PedroHLC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Can you think of any easy way for us to keep those dependencies up-to-date?

EDIT: Nevermind, I'll do a devshell with a script that will call all update scripts.

@PedroHLC PedroHLC merged commit b2d1d72 into chaotic-cx:main Jun 8, 2023
@rodrgz rodrgz deleted the river branch June 9, 2023 20:58
@rodrgz rodrgz mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroHLC PedroHLC PedroHLC approved these changes

Assignees

@rodrgz rodrgz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrgz @PedroHLC