Improve FileSystem.listdir() error message #12846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 19, 2019 12:28
Include argument given to listdir()
bradcray
reviewed
Apr 19, 2019
| errorMsg = "error in listdir() with argument '%s'".format(path); | ||
| } catch e { | ||
| // Generic error message in case format fails | ||
| perror("Error in listdir(): "); |
There was a problem hiding this comment.
It seems unlikely that C's errno would still be set properly by the time we've run through format + try/catch code paths in Chapel. Isn't it only valid immediately after the operation that set it? Seems like once we start introducing more complex code here, we should grab errno immediately and then process it within Chapel directly.
There was a problem hiding this comment.
Good point. I chatted with @lydia-duncan, and believe the right solution involves wrapping opendir() with chpl_fs_opendir() that returns a syserr, like we do with other FS calls in runtime/src/chpl-file-utils.c.
|
Not sure when I'll have a chance to revisit this, so I'm closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add argument name to
listdir()error message.Before this PR:
After this PR: