Switch Arkouda graphs to display nightly by default #22594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, Arkouda graphs show the release version by default, which means that changes to Chapel will be missed. Switching this to default to nightly will make it more obvious of Chapel-side changes that impact Arkouda. Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
ronawho
reviewed
Jun 22, 2023
| @@ -48,7 +48,7 @@ export CHPL_WHICH_RELEASE_FOR_ARKOUDA="1.30.0" | |||
| # test against Chapel release (checking out current test/cron directories) | |||
| function test_release() { | |||
| export CHPL_TEST_PERF_DESCRIPTION=release | |||
| export CHPL_TEST_PERF_CONFIGS="release:v,nightly" | |||
There was a problem hiding this comment.
This makes "release" not visible by default. See --configs option in ./util/test/genGraphs --help
There was a problem hiding this comment.
Were you thinking that we would have both of them visible by default? I was thinking we only wanted to look at nightly by default.
There was a problem hiding this comment.
I was thinking both, but let's discuss in perf meeting today
There was a problem hiding this comment.
Switched to that, that's fine with me.
Signed-off-by: Ben McDonald <46734217+bmcdonald3@users.noreply.github.com>
bmcdonald3
force-pushed
the
arkouda-graphs
branch
from
b94ef9d
to
b6a21a0
Compare
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, Arkouda graphs show the release version by default, which means that changes to Chapel will be missed. Switching this to default to nightly will make it more obvious of Chapel-side changes that impact Arkouda.