Update line numbers in .good for #24127 #24226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
mppf
approved these changes
Jan 18, 2024
vasslitvinov
added a commit
that referenced
this pull request
Jan 20, 2024
This extends the prediff for basicMem.chpl to canonicalize the size of `[domain(1,int(64),one)] int(64)` in the "allocate"/"free" lines of the test's output. In #24226 I changed basicMem.good to contain 160 instead of the previous 168 bytes in those lines. I did so based on the test behavior that I observed on my laptop. However apparently that size is platform-dependent because it is still 168 bytes in our nightly testing. Since the test is not intended to lock in the size of the array, this PR makes the prediff replace any size between 100 and 199 bytes with "1nn". Trivial, not reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reacts to #24127 analogously to #24157, following the same argument in favor of changing the line numbers vs. introducing a prediff.
Additionally, it reflects a reduction in the allocation/freeing size of
[domain(1,int(64),one)] int(64)from 168 to 160 bytes. I did not investigate where that comes from.