Fix first-class-functions as arguments to classes

[DanilaFe]

Fixes #23701.

This PR resolves an internal error that can be triggered by programs that use FCFs as arguments to classes or records:

record r {
    var containedValue;
}

var x = new r(proc() { return 42; });

The bug was that the FCF was converted into a call to a factory function (e.g. fcfFactory()), and replaced in the parent expression. However, the resolution code downstream expects a normalized program, and new r(fcfFactory()) is not normalized. This led to an assertion error.

This PR fixes the issue by introducing a new temporary to store the result of fcfFactory(). This means that the normalization of the program is preserved, and downstream code does not cause errors. Since the FCF transformation happens mid-resolution, I have to explicitly call resolveExpr to ensure the temporary and its initializer have their types computed.

[DanilaFe]

Closing in favor of #25615.