Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare slicing expression types to avoid promotion in Array View Elision support code #25478

Merged

Conversation

e-kayrakli
Copy link
Contributor

@e-kayrakli e-kayrakli commented Jul 10, 2024

A statement like

Arr1[1..9] = Arr2[{1..9}];

resulted in doing something akin to

1..9 == {1..9};

which is a promoted expression. That caused some resolution errors downstream. This PR compares chpl__protoSlice types before doing the comparison that resulted in promotion to prevent that.

Test:

  • linux64
  • gasnet

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
@e-kayrakli e-kayrakli merged commit 33dbeac into chapel-lang:main Jul 15, 2024
7 checks passed
@e-kayrakli e-kayrakli deleted the ave-fix-slicingexpr-type-mismatch branch July 15, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant