Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is supposed to add llvm tools to chapel building. By tools I mean commands like
llvm-dis
,opt
. Couple of other useful tools (which are definitely going to be useful for testing) likeFileCheck
should be built and installed as well.I can't see easy and standard way of adding only specified tools. Makefile generated by llvm's CMake contains targets like
install-FileCheck
, and we could use them to build only the necessary tools, but I feel this is a little bit hacky solution and makes build system harder to maintain.I think one good idea might be adding
llvm
directory toutils
and move some of tools there, so that the tools are easier to use in tests for example.I'd be glad if someone offered a little bit help with this because testing these changes (making sure that proper tools get built and installed) takes a lot of time on my computer as I have to rebuild chapel to make sure everything works (still not sure about this).