Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis dependency >= 3.2, < 6 #100

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

toreym
Copy link
Contributor

@toreym toreym commented Feb 14, 2023

Updating gemspec to allow redis v5.
Fix a test that did not have an id, redis v5 will error on an attempt to set a nil key in a hash.

@toreym toreym mentioned this pull request Feb 14, 2023
gush.gemspec Outdated Show resolved Hide resolved
@toreym toreym changed the title allow redis ~> 5 Update redis dependency >= 3.2, < 6 Feb 14, 2023
@pokonski
Copy link
Contributor

Thank you for the contribution! We'll probably need to start testing against various Redis versions on CI 🤔 But that's a separate topic

@pokonski pokonski merged commit e218ea1 into chaps-io:master Feb 14, 2023
@toreym
Copy link
Contributor Author

toreym commented Feb 14, 2023

🙌 Thank you for the quick response. Appreciate everything!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants