Broken function TypeScript types in version 2.34.0

[ihmpavel]

After upgrading from 2.33.0 to 2.34.0 return types are broken.

Working 2.33.0:

type CustomerRetrieveInput = Parameters<typeof Customer.retrieve>
type CustomerRetrieveOutput = Promise<{
  card: Card
  customer: Customer
}>
const customerRetrieve = (
  customerId: CustomerRetrieveInput[0],
  params?: CustomerRetrieveInput[1]
): CustomerRetrieveOutput => chargebee.customer.retrieve(customerId, params).request()

Not working 2.34.0 - same code.
Issue:

---

One liner:

---

After looking into the changes made 8a4e9fa#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R23-L27 it looks like the problem is changing @types/q from devDependencies to dependencies.

[cb-alish]

Hi @ihmpavel , thanks for reporting this and sorry for the trouble. We’ve reverted the change which caused this issue for now. Please try v2.35.0 and let us know if you still face any issue.

[ihmpavel]

Hi @cb-alish, with 2.35.0 everything works now!

Thanks