fastwalk: add new dirent package for parsing Unix dirents #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
charlievieth
force-pushed
the
cev/unix-dirent
branch
2 times, most recently
from
44cf3da
to
b8de179
Compare
This commit updates the Dirent parsing logic to match what the go1.22 stdlib uses. This is an attempt to fix FZF issue: junegunn/fzf#3706
charlievieth
force-pushed
the
cev/unix-dirent
branch
from
b8de179
to
8ba8458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with Dirent parsing junegunn/fzf#3706 by updating the logic to match what the go1.22 stdlib uses.
H/T to @2084x for reporting this issue and confirming that the fix works and to @junegunn for helping to track down and fix this.