feat: allow to set the height of the item #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user might want to show more than 2 lines, and, right now, if they try to do so, things break. Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
caarlos0
commented
May 24, 2022
|
LGTM. The original idea was to have the users implement their own Delegate should they need a more intricate (e.g. multi-line) view that goes beyond a single title and a description. Most people seem to get away with our |
muesli
approved these changes
May 24, 2022
aymanbagabas
approved these changes
May 24, 2022
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
aymanbagabas
approved these changes
May 24, 2022
muesli
approved these changes
May 24, 2022
ReallyLiri
pushed a commit
to ReallyLiri/bubbles
that referenced
this pull request
Jun 13, 2024
* feat: allow to set the height of the item The user might want to show more than 2 lines, and, right now, if they try to do so, things break. Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com> * fix: short-circuit if width <= 0 Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com> * fix: height check Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user might want to show more than 2 lines, and, right now, if they
try to do so, things break.
This also ensures the item never takes more than the allowed height, preventing issues like #117
fixes #117