Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode causes a panic in key.go #706

Closed
mosir opened this issue Mar 28, 2023 · 1 comment · Fixed by #570
Closed

Hardcode causes a panic in key.go #706

mosir opened this issue Mar 28, 2023 · 1 comment · Fixed by #570
Labels
bug Something isn't working

Comments

@mosir
Copy link

mosir commented Mar 28, 2023

Progam crashed when the length of input string more then 256.

bubbletea/key.go

Lines 568 to 575 in 248eb83

func readInputs(input io.Reader) ([]Msg, error) {
var buf [256]byte
// Read and block
numBytes, err := input.Read(buf[:])
if err != nil {
return nil, err
}

@meowgorithm
Copy link
Member

meowgorithm commented Mar 28, 2023

Thanks for the report! This will be solved by #570.

@bashbunni bashbunni linked a pull request Apr 4, 2023 that will close this issue
@bashbunni bashbunni added the bug Something isn't working label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants