Add support for gradient colours #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a struct which implements TerminalColor interface. Added steps to Render for gradient application to text
|
This looks pretty cool, even though it does complicate the common code paths a bit. I guess we could try and separate a bit of the nested rendering code. |
|
Thanks. TBH I totally forgot about this one. I remember that I couldn't figure out a clean entrypoint to accomplish this. It works and passes tests......... but I'm not sure if you have any plans to modify the Render method ever again 👹 |
Closed
Dorakim94
approved these changes
Sep 12, 2024
|
What's this? Do I need to do something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a struct which implements TerminalColor interface. Added steps to Render for gradient application to text.