Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): also build examples #310

Merged
merged 6 commits into from
Jun 4, 2024
Merged

chore(ci): also build examples #310

merged 6 commits into from
Jun 4, 2024

Conversation

meowgorithm
Copy link
Member

No description provided.

@meowgorithm
Copy link
Member Author

@aymanbagabas @caarlos0: Any idea why the SSH example doesn't build? Not working locally either, getting:

# github.com/caarlos0/sshmarshal
../../../../.go/pkg/mod/github.com/caarlos0/sshmarshal@v0.1.0/marshal.go:29:6: MarshalPrivateKey already declared through dot-import of package ssh ("golang.org/x/crypto/ssh")
        ../../../../.go/pkg/mod/golang.org/x/crypto@v0.17.0/ssh/keys.go:302:6: other declaration of MarshalPrivateKey
../../../../.go/pkg/mod/github.com/caarlos0/sshmarshal@v0.1.0/marshal.go:35:6: MarshalPrivateKeyWithPassphrase already declared through dot-import of package ssh ("golang.org/x/crypto/ssh")
        ../../../../.go/pkg/mod/golang.org/x/crypto@v0.17.0/ssh/keys.go:308:6: other declaration of MarshalPrivateKeyWithPassphrase

@aymanbagabas
Copy link
Member

github.com/caarlos0/sshmarshal

github.com/caarlos0/sshmarshal is no longer needed and can be replaced with golang.org/x/crypto ssh package.

@meowgorithm
Copy link
Member Author

Where’s the dependency? I checked charmbracelet/wish and charmbracelet/ssh and didn't see it.

@meowgorithm meowgorithm merged commit bbd02ab into master Jun 4, 2024
20 checks passed
@meowgorithm meowgorithm deleted the build-examples branch June 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants