Delete gum.json #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can instead rename it to charm-gum, yes. |
caarlos0
added a commit
to charmbracelet/meta
that referenced
this pull request
Feb 29, 2024
caarlos0
added a commit
to charmbracelet/gum
that referenced
this pull request
Feb 29, 2024
gum conflicts with another tool, even if it is in our own bucket, this still makes it difficult to install. the official scoop for gum is also called charm-gum, so I think this should work better. refs charmbracelet/scoop-bucket#7
caarlos0
added a commit
to charmbracelet/meta
that referenced
this pull request
Feb 29, 2024
|
fixed, thank you |
caarlos0
added a commit
to charmbracelet/gum
that referenced
this pull request
Mar 1, 2024
gum conflicts with another tool, even if it is in our own bucket, this still makes it difficult to install. the official scoop for gum is also called charm-gum, so I think this should work better. refs charmbracelet/scoop-bucket#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ScoopInstaller/Main/blob/master/bucket/charm-gum.json
this exists in the main bucket and so gum is no longer needed. also it's really hard to even install, because of that gradle-maven wrapper with the name gum that is already in the main bucket. because of that, to use the gum.json you need to target the exact github url
or just use charm-gum.
maybe if it's hard to keep the main bucket updated for some reason ? is it not automatic ? then it makes sense to keep a gum.json here for faster updates, but even still i'd recommend renaming to something like charm-gum-repo or something so that the conflict is removed.