feat!: Make callbacks and public_key attributes public
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <jason.nucciarone@canonical.com>
Making these attributes public enables developers to use the callbacks for parsing configuration values that do not come in through a configuration file. REST API, command line, etc. BREAKING CHANGE: These attributes are no longer protected (have the prepended underscore). Any method relying on the protected attributes will now fail since the variables are now public. Signed-off-by: Jason C. Nucciarone <jason.nucciarone@canonical.com>
NucciTheBoss
added
Priority: Medium
Signed-off-by: Jason C. Nucciarone <jason.nucciarone@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to make the
callbackandpublic_keyattributes "public" since I need them in the Slurm snap for processing configuration values that come in via the command line. Now linters will not complain about developers accessing the callbacks for performing additional parsing and marshalling when configuration changes come in from a different location that is not a Slurm-related configuration file.BREAKING CHANGES: Removes the leading underscore from the
callbacksandprivate_keyattribute. This will break anyone accessing these attributes to perform operations on Slurm configuration data.