-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LB Position API #3540
Open
rbuch
wants to merge
7
commits into
main
Choose a base branch
from
ronak/lb-position-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add LB Position API #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuch
requested review from
epmikida,
kavithachandrasekar,
PathikritGhosh and
slm960323
December 15, 2021 19:57
rbuch
force-pushed
the
ronak/lb-position-api
branch
2 times, most recently
from
December 15, 2021 22:20
c14eca1
to
b76f606
Compare
slm960323
reviewed
Jan 4, 2022
slm960323
previously approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for some inconsistency of variable type.
Allows objects to pass in a vector describing their position. LB strategies must indicate that they require object positions at registration time for the runtime to pass them.
New position API-based orthogonal recursive bisection load balancer based on ChaNGa's Orb3dLB_notopo.
rbuch
force-pushed
the
ronak/lb-position-api
branch
from
June 30, 2022 20:58
52b5552
to
032aa18
Compare
rbuch
requested review from
ericjbohm and
matthiasdiener
and removed request for
PathikritGhosh
June 30, 2022 20:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds object position API and an arbitrary-dimension ORB strategy that makes use of it.