Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect fill: false with custom draw times #10414

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Conversation

LeeLenaleee
Copy link
Collaborator

@LeeLenaleee LeeLenaleee commented Jun 9, 2022

TODO:

  • make seperate function so no code duplication
  • write test
  • Fix code (using gh build in plain editor has its limitations for quick drafts 😅 )

Need to figure out why this is breaking other filling tests.

@LeeLenaleee LeeLenaleee added this to the Version 3.8.1 milestone Jun 9, 2022
@LeeLenaleee
Copy link
Collaborator Author

Really bussy with school at the moment, so I haven't looked into this yet, think next week will be the earliest when I have time to see if I can figgure out the problems

@LeeLenaleee LeeLenaleee marked this pull request as ready for review June 21, 2022 17:26
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment

src/plugins/plugin.filler/index.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants