logarithmic scale - support of : beginAtZero, zero values, multidataset selection (issue-#9629)

[skalimer0]

beginAtZero support and zero values display on logarithmic scale with multi dataset selection.

same changes can be apply on 3.9 branch.

issue #9629

Thanks

[LeeLenaleee]

You don't need to open a new issue every time you change your code

[skalimer0]

You don't need to open a new issue every time you change your code

Sorry for that, i just want to make that clean.

[LeeLenaleee]

Some minor things, need to give it a better look later.

CI is failing atm, please make sure it passes. you can check this locally by running pnpm run test. If the linting and test pass it is good.

[kurkle]

Looks like the code already had support for zero, does it not work?

[skalimer0]

Looks like the code already had support for zero, does it not work?

The code don't display zero. Line chart is cut.

[kurkle]

Looks like the code already had support for zero, does it not work?

The code don't display zero. Line chart is cut.

true, a pen using master: https://codepen.io/kurkle/pen/KKRQpgR

[skalimer0]

And no '0' tick appear too.

[skalimer0]

Just an idea...
to support zero values, It may be better to use log1n() function instead of log10().... no ?

[skalimer0]

I check tests on scale-logarithmic, all tests with type bar are failed because bar have beginAtZero at true by default.
All test on min value on it return 0 with my code... it's normal (current master don't have beginAtZero full support). I should add beginAtZero to false or use line type on tests ?

[LeeLenaleee]

Changing the type to line is fine.

Also should add a test that beginAtZero actually works

[skalimer0]

Hello,
Please this feature can be merge on master ?

[LeeLenaleee]

The build fails, as long as that happens this can't be merged.

Also like I said in my previous comment, a test for this should be added so we get notified in the future if it breaks

[skalimer0]

For the build, sorry a mistake in my commit...

[skalimer0]

I'll do in other way later (and not in my master branch)