Bar chart with indexAxis: 'y' requires data.labels whereas 'x' doesn't. #11688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi I appreciate the PR with a fix for the problem. I have made a alternative PR to fix the issue since I don't think putting the data in the labels array is the correct fix. The underlying issue is in my eyes that the data array was always build staticly instead of dynamically. |
|
Fixed in #11690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #11684, indexAxis y requires data.labels whereas indexAxis x does not. According to the same issue y should be treated as x in this case. Where this PR solves that problem.
This is done by checking if data.labels.lenght is 0 and indexAxis set to y then we transform the data.dataset.data to set the required data.labels and data.dataset.data in order to work as expected.
Closes #11684