Ensure deprecated unitStepSize property of time scale is respected #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Jun 22, 2017
test/specs/scale.time.tests.js
Outdated
| expect(ticks).toEqual(['8PM', '10PM']); | ||
| }); | ||
|
|
||
| it('should use the stepSize property', function() { |
There was a problem hiding this comment.
I would move the deprecated option in core.deprecations.test.js
simonbrunel
reviewed
Jun 25, 2017
| } | ||
|
|
||
| it('should use the stepSize property', function() { | ||
| var mockData = { |
There was a problem hiding this comment.
Could we simply acquire a chart with minimal options and remove the createScale setup?
src/scales/scale.time.js
Outdated
| @@ -146,7 +146,8 @@ module.exports = function(Chart) { | |||
| me.unit = unit; | |||
| me.majorUnit = majorUnit; | |||
|
|
|||
| var stepSize = timeOpts.stepSize || timeHelpers.determineStepSize(minTimestamp || dataMin, maxTimestamp || dataMax, unit, maxTicks); | |||
| var optionStepSize = helpers.getValueOrDefault(timeOpts.stepSize, timeOpts.unitStepSize); | |||
There was a problem hiding this comment.
helpers.valueOrDefault() ;)
simonbrunel
approved these changes
Jun 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added tests
resolves #4391