Add back Chart.Ticks.formatters #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
expose-ticks
branch
from
ac5f291
to
d7f6173
Compare
etimberg
previously approved these changes
Dec 28, 2017
simonbrunel
previously approved these changes
Jan 6, 2018
|
Looks good, I would add unit tests ( expect(typeof Chart.Ticks).toBeDefined()
expect(typeof Chart.Ticks.formatters).toBeDefined()
expect(typeof Chart.Ticks.formatters.value).toBe('function')
// ... |
benmccann
force-pushed
the
expose-ticks
branch
from
d7f6173
to
d19bc43
Compare
|
Thanks for taking a look. I've added the tests |
simonbrunel
reviewed
Jan 6, 2018
test/specs/core.ticks.tests.js
Outdated
| it('Should expose formatters api', function() { | ||
| expect(typeof Chart.Ticks).toBeDefined(); | ||
| expect(typeof Chart.Ticks.formatters).toBeDefined(); | ||
| expect(typeof Chart.Ticks.formatters.linear).toBe('function'); |
There was a problem hiding this comment.
I think it's safer to add all:
expect(typeof Chart.Ticks.formatters.linear).toBe('function');
expect(typeof Chart.Ticks.formatters.logarithmic).toBe('function');
expect(typeof Chart.Ticks.formatters.value).toBe('function');
benmccann
force-pushed
the
expose-ticks
branch
from
d19bc43
to
01ce253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5021
Seems like we were too agressive. There's a few different people (me, @adamk33n3r, @cholt0425) that want to be able to use the default tick formatters that were previously available via
Ticks.formatters. Accordingly, this PR adds backTicks.formatters, but notTicks.generators, which is what I think we were most interested in making private