Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds midpoint interpolation to stepped plots #5908

Merged
merged 3 commits into from
Dec 18, 2018
Merged

adds midpoint interpolation to stepped plots #5908

merged 3 commits into from
Dec 18, 2018

Conversation

veggiesaurus
Copy link
Contributor

@veggiesaurus veggiesaurus commented Dec 12, 2018

This PR adds the midpoint setting to the steppedLines configuration option of line plots. An example of the new setting is shown below.

image

Fixes #4374

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veggiesaurus, can you also add associated unit tests?

docs/charts/line.md Outdated Show resolved Hide resolved
src/helpers/helpers.canvas.js Outdated Show resolved Hide resolved
@veggiesaurus
Copy link
Contributor Author

requested changes added

@simonbrunel simonbrunel added this to the Version 2.8 milestone Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants