-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed contribution docs #5968
fixed contribution docs #5968
Conversation
Thanks @mojoaxel for your suggestion.
Only
Actually, the documentation is wrong, it should be: > npm install
> npm install -g gulp-cli
I don't like the idea of mixing npm and gulp commands, it's confusing and at some point we will be asked to duplicate gulp commands to npm, which is useless and require more maintenance. Also, I don't think |
I had a lot of problems getting this to run with my current node (nvm) setup. 😡 To be honest I'm not a big fan of installing things globally, but I guess that is a I'll fix at least the docs...
I see 😐 |
Ok, at least I fixed the docs 😉 |
Thanks @mojoaxel I'm not fan either of installing stuff globally :) but I think it works pretty well for |
Thanks @mojoaxel |
Update the docs so that only gulp-cli is installed globally
This makes it possible to use the local version of gulp (from
node_modeues/gulp
) to build the library.The current builds e.g.
gulp build
of course still work if gulp is globally installed. If gulp is only installed locally vianpm install
than the user should usenpm run gulp
to do the same.This way it is possible to use different versions of gulb for different projects.
I also added the common npm build scripts:
npm start
andnpm test
, because they are a common go-to for new developers.I hope you like these suggestions