-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note about maintainAspectRatio #5974
Added note about maintainAspectRatio #5974
Conversation
Thanks @janelledement. I would have expected the chart to resize to fit in its parent (something like CSS Your statement only applies to modifying the height, so I would update the example to also include changing the width:
Then modify your note to be something like:
|
@simonbrunel Yes, I agree, thank you for the response! Change made |
Thanks @janelledement |
Add a note about resizing the chart height with maintainAspectRatio
Hi there,
This is rather a small documentation request, but do you think it might be worth it to explicitly say in the responsive.md file that in order for the given example to work, maintainAspectRatio property must be set to false? Here is a screenshot of the part I'm referring to:
I realize that in the example codepen you provide, the said property is set to false. However, when I created my first chart, I just ran what I saw on the page above, then scratched my head for a while when it didn't work as I expected it to. I ended up comparing my code with the codepen example and eventually figured it out.
I'm thinking that by making a small note about the property on the documentation page might cost someone less mental overhead and time in the future.
Thanks for your consideration!