Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement per-dataset type (default and per-chart) options #5999

Merged
merged 11 commits into from
May 6, 2019
Merged

Implement per-dataset type (default and per-chart) options #5999

merged 11 commits into from
May 6, 2019

Conversation

benmccann
Copy link
Contributor

This fixes mixed line and scatter charts. Issue described in #4587

Closes #5997 & #5151

@benmccann benmccann mentioned this pull request Jan 21, 2019
Closed
kurkle
kurkle reviewed Jan 21, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the discussion in Slack, this seems like a good start!

karma.conf.js Outdated Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
src/core/core.datasetController.js Outdated Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
@benmccann benmccann force-pushed the controller-default-opts branch 5 times, most recently from 15dd6bf to 0b86cf9 Compare January 21, 2019 18:46
simonbrunel
simonbrunel requested changes Jan 22, 2019
View reviewed changes
src/controllers/controller.line.js Outdated Show resolved Hide resolved
src/controllers/controller.scatter.js Show resolved Hide resolved
src/core/core.datasetController.js Outdated Show resolved Hide resolved
src/core/core.datasetController.js Show resolved Hide resolved
kurkle
kurkle previously approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

simonbrunel
simonbrunel requested changes Jan 23, 2019
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor update in _defaults.

We also need unit tests per controller (line + scatter) to make sure that dataset defaults are correctly handled for every options. And I guess we also need to update the docs about configuring dataset defaults.

src/core/core.datasetController.js Outdated Show resolved Hide resolved
@benmccann
Copy link
Contributor Author

We also need unit tests per controller (line + scatter) to make sure that dataset defaults are correctly handled for every options.

The line chart showLine option was already well tested. I added additional tests for spanGaps and for scatter's showLine.

And I guess we also need to update the docs about configuring dataset defaults.

We don't allow users to configure default options. defaults._set is private

@benmccann benmccann force-pushed the controller-default-opts branch 4 times, most recently from 3c0bad6 to 1be7103 Compare January 29, 2019 17:25
kurkle
kurkle requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line to remove and a question to consider.

src/core/core.datasetController.js Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
@simonbrunel
Copy link
Member

We don't allow users to configure default options. defaults._set is private

_set is indeed an internal helper but users are allowed to modify Chart.defaults.datasets.*. So since we are introducing a new public API that allows users to configure defaults for all dataset options, we should also add unit tests for it.

@benmccann
Copy link
Contributor Author

Ok, I went ahead and added documentation. I had already added unit tests

nagix
nagix reviewed Feb 4, 2019
View reviewed changes
docs/configuration/README.md Outdated Show resolved Hide resolved
@benmccann benmccann force-pushed the controller-default-opts branch 5 times, most recently from b0bd6f4 to 5c3f88f Compare February 12, 2019 04:20
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Implement per-dataset type (default and per-chart) options (chartjs#5999
b88f522 
)
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@MatsNissen-Lie
Copy link

I want to combined the candlestick chart with a line chart. Is that possible, and if so, how?

@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

@nagix nagix nagix approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg Awaiting requested review from etimberg

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
6 participants
@benmccann @simonbrunel @MatsNissen-Lie @nagix @etimberg @kurkle