Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate configMerge and scaleMerge helpers #6022

Merged
merged 5 commits into from
Jan 29, 2019
Merged

Deprecate configMerge and scaleMerge helpers #6022

merged 5 commits into from
Jan 29, 2019

Commits on Jan 28, 2019

  1. Deprecate configMerge and scaleMerge helpers 

    These methods shouldn't have been public since they are specific to the chart controller internal logic. Note that this scale custom merging will be removed in v3.
    @simonbrunel
    simonbrunel committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    4b0dc2f View commit details
    Browse the repository at this point in the history

  2. Add deprecation tests (and fix lint error)

    @simonbrunel
    simonbrunel committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    dac95fd View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Prevent explicit first argument deep copy

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    1d4b41a View commit details
    Browse the repository at this point in the history

  2. [].slice instead of Array.prototype.slice

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    445cf19 View commit details
    Browse the repository at this point in the history

  3. Update comment per code review

    @simonbrunel
    simonbrunel committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    104991b View commit details
    Browse the repository at this point in the history