-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc on label types for TooltipItem #6030
Conversation
I was debating that as well. That approach would make sense to me |
I agree they should be strings. That is not the case (yet) though, and these changes reflect current situation. |
If users expect |
For these new ones, yes I think they should be formatted and/or forced to string before 2.8 release. |
Now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for adding tests!
Also update the docs for `xLabel` and `yLabel` to also accept a `number`.
Also update the docs for `xLabel` and `yLabel` to also accept a `number`.
Also update the docs for `xLabel` and `yLabel` to also accept a `number`.
Also update the docs for `xLabel` and `yLabel` to also accept a `number`.
label
andvalue
inTooltipItem
are the return values fromscale.getLabelForIndex
which can benumber
orstring
.Fixes #5830