Improvements to helpers.almostWhole #6120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
previously approved these changes
Mar 10, 2019
nagix
previously approved these changes
Mar 11, 2019
|
@benmccann can you resolve conflicts then we can merge? |
benmccann
force-pushed
the
decimal-places
branch
from
75fa2ad
to
aaf83b1
Compare
|
@simonbrunel I've rebased this PR. Thanks for the review |
kurkle
approved these changes
Mar 18, 2019
nagix
approved these changes
Mar 18, 2019
etimberg
approved these changes
Mar 18, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the agreed upon parts of #5992. I'm going to close that PR for the time being to keep the review queue clear until we have an agreed upon path forward
epsiloninclusive and adds corresponding tests foralmostWhole. Thanks @costerwi for the suggestion in Enhance helper.decimalPlaces #5992decimalPlacesas suggested by @kurkle in https://github.com/chartjs/Chart.js/pull/5992/files#r249953203