Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arc size calculation when circumference is under 2PI #6224

Merged
merged 2 commits into from
May 1, 2019
Merged

Fix arc size calculation when circumference is under 2PI #6224

merged 2 commits into from
May 1, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Apr 25, 2019

In doughnut and pie charts, an arc border is cut off when the circumference is under 2*PI. This PR fixes it.

Master: https://jsfiddle.net/nagix/cbma01yp/
Screen Shot 2019-04-25 at 5 17 20 PM

This PR: https://jsfiddle.net/nagix/7cxub8qf/
Screen Shot 2019-04-25 at 5 18 24 PM

kurkle
kurkle previously approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

etimberg
etimberg previously approved these changes Apr 25, 2019
View reviewed changes
benmccann
benmccann previously approved these changes Apr 26, 2019
View reviewed changes
@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 26, 2019
@nagix nagix dismissed stale reviews from benmccann, etimberg, and kurkle via 799d0bb May 1, 2019 08:09
@nagix
Copy link
Contributor Author

nagix commented May 1, 2019

Refactoring is done. This saves 351 bytes.

simonbrunel
simonbrunel approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nagix, it's way more readable now

@simonbrunel simonbrunel merged commit 4f722ab into chartjs:master May 1, 2019
@nagix nagix deleted the issue-6224 branch May 1, 2019 16:35
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @simonbrunel
Fix arc size calculation when circumference is under 2PI (chartjs#6224)
9615917
This was referenced Jun 1, 2021
Closed
Merged
Closed
This was referenced Jun 6, 2021
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@simonbrunel simonbrunel simonbrunel approved these changes

@kurkle kurkle kurkle approved these changes

@etimberg etimberg etimberg left review comments

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@nagix @benmccann @simonbrunel @etimberg @kurkle