-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label alignment option to axis label title #6521
Conversation
@el the build is failing. Please make sure |
Is |
I wasn't thinking the scale start for |
I think we should consider the start point the same for left or right axes. As @kurkle mentioned, this should respect the |
What if all the data is negative? Then the axis start would be the top. Or if the data have negative and positive values, then the start would in the middle. |
Start (lowest value) will still be at bottom, unless |
Updated codepen with start at bottom on right axis, and reverse support: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than reverse for horizontal scales, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just a couple minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverse
is not working correctly for horizontal scales.
So, I have created this page to test all possible variations: https://codepen.io/elizzk/pen/PoYBRWX?editors=0010
I |
Do we need any other changes for this? @kurkle @benmccann @etimberg |
I would love if there was an option to put the axis label at the top (if it was Y-axis; like so) link to the issue on StackOverflow: https://stackoverflow.com/questions/53797324/chartjs-align-axis-label-to-the-top |
Change in action: https://codepen.io/elizzk/pen/PoYBRWX
Closes: #6515