Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (excluding typescript) #8856

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Apr 8, 2021

With typescript 4.2 (.3 and .4 at least) the tests fail:

[lint-types] types/tests/test_instance_assignment.ts(19,3): error TS2322: Type 'Chart<"scatter", { x: number; y: number; }[], never>' is not assignable to type 'Chart<keyof ChartTypeRegistry, (number | ScatterDataPoint | BubbleDataPoint | null)[], unknown>'.
[lint-types]   The types of 'config.options' are incompatible between these types.
[lint-types]     Type '_DeepPartialObject<CoreChartOptions<"scatter"> & ElementChartOptions & PluginChartOptions<"scatter"> & DatasetChartOptions<"scatter"> & ScaleChartOptions<...> & LineControllerChartOptions> | undefined' is not assignable to type '_DeepPartialObject<CoreChartOptions<keyof ChartTypeRegistry> & ElementChartOptions & PluginChartOptions<keyof ChartTypeRegistry> & DatasetChartOptions<...> & ScaleChartOptions<...>> | undefined'.
[lint-types]       Type '_DeepPartialObject<CoreChartOptions<"scatter"> & ElementChartOptions & PluginChartOptions<"scatter"> & DatasetChartOptions<"scatter"> & ScaleChartOptions<...> & LineControllerChartOptions>' is not assignable to type '_DeepPartialObject<CoreChartOptions<keyof ChartTypeRegistry> & ElementChartOptions & PluginChartOptions<keyof ChartTypeRegistry> & DatasetChartOptions<...> & ScaleChartOptions<...>>'.
[lint-types]         Types of property 'layout' are incompatible.
[lint-types]           Type '_DeepPartialObject<{ padding: Scriptable<number | ChartArea, ScriptableContext<"scatter">>; }> | undefined' is not assignable to type '_DeepPartialObject<{ padding: Scriptable<number | ChartArea, ScriptableContext<keyof ChartTypeRegistry>>; }> | undefined'.
[lint-types]             Type '_DeepPartialObject<{ padding: Scriptable<number | ChartArea, ScriptableContext<"scatter">>; }>' is not assignable to type '_DeepPartialObject<{ padding: Scriptable<number | ChartArea, ScriptableContext<keyof ChartTypeRegistry>>; }>'.
[lint-types]               Types of property 'padding' are incompatible.
[lint-types]                 Type 'number | _DeepPartialObject<ChartArea> | ((ctx: ScriptableContext<"scatter">) => number | ChartArea) | undefined' is not assignable to type 'number | _DeepPartialObject<ChartArea> | ((ctx: ScriptableContext<keyof ChartTypeRegistry>) => number | ChartArea) | undefined'.
[lint-types]                   Type '(ctx: ScriptableContext<"scatter">) => number | ChartArea' is not assignable to type 'number | _DeepPartialObject<ChartArea> | ((ctx: ScriptableContext<keyof ChartTypeRegistry>) => number | ChartArea) | undefined'.
[lint-types]                     Type '(ctx: ScriptableContext<"scatter">) => number | ChartArea' is not assignable to type '(ctx: ScriptableContext<keyof ChartTypeRegistry>) => number | ChartArea'.

@kurkle kurkle added the dependencies Pull requests that update a dependency file label Apr 8, 2021
@etimberg etimberg added this to the Version 3.1 milestone Apr 8, 2021
@etimberg etimberg merged commit 5b4aad7 into chartjs:master Apr 8, 2021
@kurkle kurkle deleted the deps31 branch May 30, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants