Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a constance spacing between arc elements #9180

Merged
merged 5 commits into from
May 29, 2021
Merged

Allow setting a constance spacing between arc elements #9180

merged 5 commits into from
May 29, 2021

Conversation

etimberg
Copy link
Member

Resolves #4990

spacing and offset

@etimberg etimberg added this to the Version 3.4.0 milestone May 29, 2021
kurkle
kurkle reviewed May 29, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised you did not have to change any old fixtures

src/controllers/controller.doughnut.js Show resolved Hide resolved
@etimberg
Copy link
Member Author

Size Change: +520 B (0%)

Total Size: 245 kB

Filename Size Change
dist/chart.esm.js 70.6 kB +216 B (0%)
dist/chart.js 89.6 kB +182 B (0%)
dist/chart.min.js 63.8 kB +122 B (0%)

kurkle
kurkle approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@etimberg
Copy link
Member Author

Thanks. I figure we should release a v3.3.1 first, so will merge this after that goes out. I think #9181 should be the last thing in 3.3.1

@etimberg etimberg merged commit c853ca6 into chartjs:master May 29, 2021
@etimberg etimberg deleted the arc-offset-implementation branch April 16, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.4.0
Development

Successfully merging this pull request may close these issues.

[Feature] Spacing between doughnut bar chart
2 participants
@etimberg @kurkle