Ensure getPrototypeOf will not crash on plugin options with no scopes #9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jul 19, 2021
|
No, I haven't tried that. That looks like a better solution, so I'll explore it |
Did you forget this, or just busy? :) |
|
Totally forgot! Will try and get to this today |
kurkle
approved these changes
Jul 24, 2021
|
@etimberg Hey was this fix reverted? It doesn't seem to exist in the project, and I cant find the commit in the commit history for src/helpers/helpers.config.js I get the same issue this fix addressed while using chart.js in AlpineJs. I re-introduced it locally in my project and it did resolve the problem for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9368