Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable animations for BasicPlatform (offcreen) #9751

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Disable animations for BasicPlatform (offcreen) #9751

merged 2 commits into from
Oct 11, 2021

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Oct 11, 2021

Closes #9749
Closes #9750

Ref #9750 (comment)

Also enables any other changes to config that a platform would require.

@kurkle kurkle requested a review from etimberg October 11, 2021 17:38
etimberg
etimberg previously approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here is fine. I think the BasePlatform type in index.esm.d.ts needs to be updated as well

@kurkle
Copy link
Member Author

kurkle commented Oct 11, 2021

@LeeLenaleee what do you think?

LeeLenaleee
LeeLenaleee approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes a lot of sense since it will save some headache in looking in docs/issues why its not working

@etimberg etimberg added this to the Version 3.6.0 milestone Oct 11, 2021
@etimberg etimberg merged commit bc5e5cb into chartjs:master Oct 11, 2021
@LeeLenaleee LeeLenaleee mentioned this pull request Apr 19, 2022
Closed
@el
Copy link
Contributor

el commented May 30, 2022

This change breaks animation generation on nodejs.

@kurkle kurkle deleted the disable-anims-for-basic branch June 29, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 3.6.0
Development

Successfully merging this pull request may close these issues.

Web workers - window error
4 participants
@kurkle @el @etimberg @LeeLenaleee