Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defined and loaded elements to annotation context #869

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented Mar 15, 2023

Fix #865

This PR is adding the state elements array to the annotation elements context.
This enables the user to use the previously annotation element properties for another annotation by scriptable option.

TODO

  • test case
  • doc
  • types

@stockiNail stockiNail modified the milestones: 3.0.0, 3.1.0 Mar 16, 2023
@stockiNail stockiNail marked this pull request as ready for review May 16, 2023 08:47
@stockiNail stockiNail closed this May 22, 2023
@stockiNail stockiNail reopened this May 22, 2023
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee I cannot merge because the checks are not available anymore and therefore the button is disable. I can switch to draft and again to ready for review in order to execute again the GHAs.

@stockiNail stockiNail merged commit 87de801 into chartjs:master Sep 19, 2024
9 checks passed
@stockiNail stockiNail deleted the linkedAnnotation branch September 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get other annotations width from an annotation scriptable option.
2 participants