Add setup for integration tests and other test-related fixes #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 438cc5c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 77.1%. View more on Code Climate. |
briwa
commented
Apr 12, 2023
| @@ -11,7 +11,7 @@ composer: | |||
| dependencies: | |||
| make -s composer update -- --prefer-dist | |||
| test: | |||
| $(RUNNER) "phpunit --coverage-text --coverage-html ./coverage" | |||
| $(RUNNER) "XDEBUG_MODE=coverage phpunit --coverage-text --coverage-html ./coverage" | |||
There was a problem hiding this comment.
This fixes an issue where the env variable is missing, so the coverage isn't being printed out when running make test
Error: missing env
briwa
commented
Apr 12, 2023
Comment on lines
+42
to
+45
| "config": { | ||
| "allow-plugins": { | ||
| "php-http/discovery": false | ||
| } |
There was a problem hiding this comment.
This fixes a prompt that kept showing up when doing make composer install:
Prompt to remove
Setting it to false so that it won't install any other plugins suggested and we can stick to the composer dependencies
Comment on lines
-3
to
+7
| <coverage> | ||
| <include> | ||
| <filter> | ||
| <whitelist> | ||
| <directory suffix=".php">./src</directory> | ||
| </include> | ||
| </coverage> | ||
| </whitelist> | ||
| </filter> |
There was a problem hiding this comment.
Similarly this is to fix the error for coverage
Error: coverage: element is not expected
pkopac
approved these changes
Apr 12, 2023
briwa
changed the title
swember
approved these changes
Apr 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-vcrcomposer.jsonwithphp-discoveryallow-plugins optionmake testcoverageBefore (main branch)
After