Added retry logic

[hassansin]

• Retry on 429, [500,600) statuses
• Retry on network releated errors
• Retry for maximum 15 mins

[pkopac]

Why not dependent on updating dependencies anymore?

[hassansin]

Installing dependencies before each command is good practice but not required. But unlike go get, composer update is very slow and I've to wait like 5-10 seconds before seeing any test output. Go frustrated and removed it.

[bogdanguranda]

Just some formatting here: ! is not near is_null

[hassansin]

hmm, wonder why php_codesniffer didn't fix it 🤔

[bogdanguranda]

What happens if this is true $attempt >= $maxAttempts, meaning it reached the maximum number of retries, but this is false !is_null($ex), meaning there was no exception thrown? It doesn't look like it will stop.
Shouldn't this check be with || instead of &&?

[en0ma]

I would actually like to know the answer to @bogdanguranda question

[hassansin]

So if there is no exception and the HTTP status isn't 429/5xx, then the function would return null (falsy value) and we would never retry. So $attempt would never exceed $maxAttempts.

[bogdanguranda]

Ok. And it will actually get here:

        if (!is_null($response)) {
            return $attempt < $maxAttempts && $this->retryHTTPStatus($response->getStatusCode());
        }

And this will return false which is correct, as attempts exceeded max attempts.

[en0ma]

LGTM

[bogdanguranda]

🏅