refactor flag filter to method

Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>

cmd/chart-scanner/main.go

@@ -17,6 +17,8 @@ var (
 
 	// Revision is the git commit id (added at compile time)
 	Revision string
+
+	exitCode int
 )
 
 func main() {
@@ -25,17 +27,21 @@ func main() {
 	app.Name = "chart-scanner"
 	app.Version = fmt.Sprintf("%s (build %s)", Version, Revision)
 	app.Usage = "checks a storage directory for evil charts"
+	app.Flags = buildCliFlags()
 	app.Action = cliHandler
+	app.Run(os.Args)
+}
+
+func buildCliFlags() []cli.Flag {
 	var flags []cli.Flag
 	for _, flag := range config.CLIFlags {
 		name := flag.GetName()
 		if name == "debug" || strings.HasPrefix(name, "storage") {
 			flags = append(flags, flag)
 		}
 	}
-	app.Flags = flags
-	sort.Sort(cli.FlagsByName(app.Flags))
-	app.Run(os.Args)
+	sort.Sort(cli.FlagsByName(flags))
+	return flags
 }
 
 func cliHandler(c *cli.Context) {
@@ -55,4 +61,6 @@ func cliHandler(c *cli.Context) {
 
 	debug := conf.GetBool("debug")
 	scan(backend, "", debug)
+
+	os.Exit(exitCode)
 }

cmd/chart-scanner/scan.go

@@ -30,4 +30,7 @@ func validateChartPackage(filePath string, debug bool) {
 	if debug {
 		log.Printf("DEBUG %s is valid\n", filePath)
 	}
+
+	exitCode = 1
+	log.Printf("ERROR %s is invalid: bad chart name\n", filePath)
 }