Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch Profile support #132

Closed
pajlada opened this issue Apr 24, 2021 · 9 comments · Fixed by #680
Closed

Twitch Profile support #132

pajlada opened this issue Apr 24, 2021 · 9 comments · Fixed by #680
Assignees
Labels
enhancement external service support This issue pertains to adding support for a specific website or service (e.g.YouTube rich thumbnail) good first issue

Comments

@pajlada
Copy link
Member

pajlada commented Apr 24, 2021

What service do you want support added for?

Add support for twitch.tv profile links

Links

  1. https://twitch.tv/pajlada
  2. https://www.twitch.tv/forsen
  3. https://www.twitch.tv/fourtf

Thumbnail

Profile image
Live status?
Bio?
Followers?

Additional information

https://dev.twitch.tv/

@pajlada pajlada added enhancement external service support This issue pertains to adding support for a specific website or service (e.g.YouTube rich thumbnail) good first issue labels Apr 24, 2021
@pajlada
Copy link
Member Author

pajlada commented Apr 24, 2021

I've marked this as a good first issue - if you want to start working on this please let me know and I will assign you to this issue so we don't get duplicate work done.

@leon-richardt
Copy link
Contributor

leon-richardt commented Apr 24, 2021

Also make sure links such as

are handled correctly

@jupjohn
Copy link
Contributor

jupjohn commented Jun 22, 2021

Happy to pick up after #157 is closed

@jupjohn
Copy link
Contributor

jupjohn commented Jul 11, 2021

helix package doesn't have the created_at field exported for users. Created a PR to add it.

@pajlada
Copy link
Member Author

pajlada commented Oct 10, 2023

This one is open for grabs if anyone wants to check this out, happy to help guide anyone looking to make their first contribution

@silaselisha
Copy link

silaselisha commented Apr 25, 2024

@pajlada I would like to make my first contribution. I'll appreciate your guidance.

@pajlada
Copy link
Member Author

pajlada commented Apr 25, 2024

This should be part of the internal/resolvers/twitch package
You have to extend the TwitchAPIClient defined in its initialize.go file to support this function
You need to define an additional resolver (see its Clip Resolver) that matches Twitch profile URLs, that then call the above-mentioned function to get information about the user
I'm not sure exactly what information would be nice to show, or in what format. I'd be happy to let you experiment with that and see what you think works best, and then we can iterate on that together.

Let me know if that helps or if there's any further guidance that would be useful @silaselisha

@silaselisha
Copy link

@pajlada I'll experiment with this, for any query I'll let you know.

@M4tthewDE
Copy link
Contributor

I would like to build a resolver for twitch users, feel free to assign the issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement external service support This issue pertains to adding support for a specific website or service (e.g.YouTube rich thumbnail) good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants