Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding audio #12

Open
chavi362 opened this issue Aug 31, 2023 · 19 comments
Open

adding audio #12

chavi362 opened this issue Aug 31, 2023 · 19 comments
Assignees
Labels
enhancement New feature or request java-script

Comments

@chavi362
Copy link
Owner

Currently, the Icy Tower game lacks audio support, which greatly affects the overall gaming experience. In order to enhance the gameplay and make it more immersive, we need to add audio features to various game events. This issue aims to implement the following audio functionalities:

  1. Create an "audio" folder:

    • Create a new folder named "audio" in the game's directory to store all the audio files related to different game events.
  2. Audio for wall time:

    • Add audio to indicate the passage of time while climbing the walls. This audio should play continuously in the background while the character is climbing.
  3. Special audio for climbing on a new stone:

    • Implement a unique sound effect that plays each time the character successfully climbs onto a new stone. This audio should signify progress and success in the game.
  4. Audio for falling and game over:

    • Include an audio cue when the character falls and the game ends. This audio should indicate the failure and conclusion of the game, creating a more engaging experience for the player.
  5. Applause sound effect after the game ends:

    • Add an applause sound effect to play once the game is over. This audio will serve as positive reinforcement and add a sense of accomplishment for the player.
  6. Audio during score display:

    • Introduce a short audio clip when displaying the final score. This audio should create a satisfying moment for the player and encourage them to improve their performance.

It is expected that the audio files used for these features will be in a compatible format and stored in the "audio" folder added to the game's repository.

Please note that the implementation of audio support may require adjustments to the game's codebase to integrate the

@chavi362 chavi362 added enhancement New feature or request java-script labels Aug 31, 2023
@HadassaAvimor
Copy link
Contributor

HadassaAvimor commented Sep 8, 2023

@chavi362 I would like to add audio to the game, please assign this issue to me, and direct me to the copyright free music link, if you have.
Thanks!

@chavi362
Copy link
Owner Author

chavi362 commented Sep 9, 2023

I assigned you. Thank you so much!!! Good Luck...
If you know some help, please let me know
I'm trying to find some audio to give you a link

@chavi362
Copy link
Owner Author

chavi362 commented Sep 9, 2023 via email

@HadassaAvimor
Copy link
Contributor

@chavi362 I opened a pull request of adding music and sound to the game.
I did not add when the game ends, nor when during score display,
Because it seemed too much to me.
I took the music and sound from the free site https://pixabay.com/,
Still, I would like you to write in the Readme file that if someone has a copyright claim to contact us and we will remove their music.

@chavi362
Copy link
Owner Author

@HadassaAvimor , Thank you so much!!
The game became so cute!
Does anyone wants to add music while jumping on a block or when the game end?

@N3v1
Copy link
Contributor

N3v1 commented Oct 10, 2023

@chavi362 Maybe I can help too. Can you please assign this issue to me

@HadassaAvimor Do you currently work on this issue?

@N3v1
Copy link
Contributor

N3v1 commented Oct 10, 2023

Thank you very much @chavi362

@chavi362
Copy link
Owner Author

Thank you so much @N3v1
I'm happy to hear from you again!!!
Hadasa Avimor doesn't work on it current now
I'll be happy for your help!

@N3v1
Copy link
Contributor

N3v1 commented Oct 10, 2023

I had a lot of tasks to take care of, so unfortunately, I wasn't able to contribute here ☹️

@N3v1
Copy link
Contributor

N3v1 commented Oct 10, 2023

I'll be done until tomorrow @chavi362

@chavi362
Copy link
Owner Author

chavi362 commented Oct 10, 2023 via email

@chavi362
Copy link
Owner Author

@N3v1 , How is your work?
Do you need some help?

@N3v1
Copy link
Contributor

N3v1 commented Oct 30, 2023 via email

@tanzimchowdh
Copy link

Hello, I'm a student at the University of Michigan looking to make my first open source contribution as part of course work. I'd like to give this issue a try if there are still game events that need audio assigned. Please direct me to other issues as well if this one is not in need of more contribution.

@chavi362
Copy link
Owner Author

chavi362 commented Nov 6, 2023

First of all, welcome to Github!!!
We would be very happy to receive your contribution! If you like Java script and games, you've come to the right place,
What we currently lack is a falling sound when the character falls as well as a short sound when the character jumps.
I recommend you play the game first (maybe even once) to understand it.
If you need further help, please write to me here.
Please give the project a star!

@tanzimchowdh
Copy link

Thank you @chavi362, I've downloaded the game and played around with it a bit. I know how I can add audio for jumping, but I am still looking into the falling portion. I also noticed that when verifying password upon signup, the verify password field is not hidden. could you make a new issue in github for this and assign that to me as well?

@chavi362
Copy link
Owner Author

chavi362 commented Nov 9, 2023

Thank you!!
I'm opening an issue right now, (if you want you can open a new issue by yourself)
Good Luck!

@chavi362
Copy link
Owner Author

chavi362 commented Dec 3, 2023

@tanzimchowdh how is your work?

@chavi362
Copy link
Owner Author

@tanzimchowdh are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java-script
Projects
None yet
Development

No branches or pull requests

4 participants