Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ga events to storyblok buttons #909

Merged
merged 3 commits into from
May 17, 2024

Conversation

SangilYun
Copy link
Contributor

Issue link / number:

#891

What changes did you make?

Added onClick event to trigger GA event to Storyblok button

Why did you make the changes?

To know how the buttons are used.

Did you run tests?

Yes

Copy link

vercel bot commented May 15, 2024

@SangilYun is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@@ -2,6 +2,9 @@ import { Box, Button } from '@mui/material';
import { storyblokEditable } from '@storyblok/react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referred to how LanguageMenu.tsx component is logging events

@kyleecodes kyleecodes self-assigned this May 17, 2024
Copy link
Member

@kyleecodes kyleecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

Note: Can confirm it functions with the Google Analytics extension.

@kyleecodes kyleecodes merged commit 303a108 into chaynHQ:develop May 17, 2024
3 of 4 checks passed
@cypress cypress bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants