This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
Add support for sandbox API keys in the request command #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmn. For some reason I thought this was set so sandbox was always used. I still feel like sandbox should be the default. What do you think? |
|
I think using the sandbox is more of an edge case than using it for production TBH |
|
Hmmmn. Maybe it's a per-command sort of thing. For instance creating a demo-store (and seeding) with production keys is more of an edge case. Although, in the context of seeding, I'm not sure how sandbox secret keys actually differ from non-sandbox 😖 Prod seems fine. The demo-store command can just use sandbox keys though. |
|
At the moment the sandbox keys don't do much, but they probably will in future. We should design with that in mind now. |
Also enables PATCH method support in this command, which may be used in the Chec API in future. If that happens, users should not need to update their CLI to use PATCH APIs
|
Rebased |
robbieaverill
force-pushed
the
feature/sandbox-mode-in-request
branch
from
2c1e44a
to
2472942
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enables PATCH method support in this command, which may be used in the Chec API in future. If that happens, users should not need to update their CLI to use PATCH APIs.
Resolves #14