Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PI-1738: Billing Form component: Standard #144

Closed
wants to merge 55 commits into from
Closed

PI-1738: Billing Form component: Standard #144

wants to merge 55 commits into from

Commits on May 10, 2022

  1. PI-1738: Billing form component: standard

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a3ddaae View commit details
    Browse the repository at this point in the history

  2. Fix logging issue

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1d5aae9 View commit details
    Browse the repository at this point in the history

  3. Fix DefaultFormStylePostcodedCell typo

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    02641fb View commit details
    Browse the repository at this point in the history

  4. Fix 'hight' typo

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8bb68d2 View commit details
    Browse the repository at this point in the history

  5. Fix typo in folder name

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0201e01 View commit details
    Browse the repository at this point in the history

  6. remove explicite Bool

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0f918de View commit details
    Browse the repository at this point in the history

  7. Fix 'BillForm' to be BillingForm

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4373e90 View commit details
    Browse the repository at this point in the history

  8. Remove unused commented code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e2efe8f View commit details
    Browse the repository at this point in the history

  9. fix deleagte typo

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    86fed89 View commit details
    Browse the repository at this point in the history

  10. Renaming some variables doneButton and cancelButton

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    77e1998 View commit details
    Browse the repository at this point in the history

  11. Update UIColor+Extension

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    3551409 View commit details
    Browse the repository at this point in the history

  12. remove unused code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    311a63a View commit details
    Browse the repository at this point in the history

  13. Renaming correction

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7a61071 View commit details
    Browse the repository at this point in the history

  14. Following the same code style pattern, remove extra self

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    88bc829 View commit details
    Browse the repository at this point in the history

  15. Simplifying the code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d0f46cf View commit details
    Browse the repository at this point in the history

  16. Remove unused import UIKit

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f94e42a View commit details
    Browse the repository at this point in the history

  17. Use XCTAssertFalse or XCTAssertTrue instead of XCTAssertEqual

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5b742d9 View commit details
    Browse the repository at this point in the history

  18. Clean code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    9e5b7a2 View commit details
    Browse the repository at this point in the history

  19. Support localised strings

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ca3e7a9 View commit details
    Browse the repository at this point in the history

  20. Clean validators code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    42a7f4e View commit details
    Browse the repository at this point in the history

  21. Fix phone number clears after scrolling off of view (unable to click … 

    …done as result)
    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a7e0c31 View commit details
    Browse the repository at this point in the history

  22. Header is currently part of the scroll view and can be scrolled off o… 

    …f the screen.

Remove BillingFormCellType raw Int type
    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d56979d View commit details
    Browse the repository at this point in the history

  23. Update updateRow code to be without implicitly capturing self

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1674596 View commit details
    Browse the repository at this point in the history

  24. Update UIColor initialisation using hex

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ba10ffe View commit details
    Browse the repository at this point in the history

  25. Rename inActive to disabled

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    31c2a02 View commit details
    Browse the repository at this point in the history

  26. Update phoneNumberKit to be private

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    44fe199 View commit details
    Browse the repository at this point in the history

  27. Update partialFormatter to be lazy

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7b6b139 View commit details
    Browse the repository at this point in the history

  28. Sorted BillingFormPhoneNumberText variables by their access level

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    64559f6 View commit details
    Browse the repository at this point in the history

  29. Update delegate to be weak

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    fc01d9c View commit details
    Browse the repository at this point in the history

  30. Add keyboardType to be .phonePad for BillingFormPhoneNumberText

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    96ee26c View commit details
    Browse the repository at this point in the history

  31. Clean code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    f1dbfe5 View commit details
    Browse the repository at this point in the history

  32. Update Localization

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    347c106 View commit details
    Browse the repository at this point in the history

  33. Update Example test UI Test

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e77207e View commit details
    Browse the repository at this point in the history

  34. Fix Test cases

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    52267b1 View commit details
    Browse the repository at this point in the history

  35. Support Carthage

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    4045c05 View commit details
    Browse the repository at this point in the history

  36. Support Pods

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d554c26 View commit details
    Browse the repository at this point in the history

  37. Update checkoutEventLoggerKitVersion to 1.2.0

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    3fa1922 View commit details
    Browse the repository at this point in the history

  38. Change textfield color to red when it has error

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    db069fa View commit details
    Browse the repository at this point in the history

  39. Fix screen leading and trailing

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d1df920 View commit details
    Browse the repository at this point in the history

  40. Update country code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ecea7cd View commit details
    Browse the repository at this point in the history

  41. Expose DefaultBillingFormViewModel delegate

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    b366298 View commit details
    Browse the repository at this point in the history

  42. Rename setupViews to setupViewsInOrder

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0634474 View commit details
    Browse the repository at this point in the history

  43. Clean test cases

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    dbd2ef5 View commit details
    Browse the repository at this point in the history

  44. clean code

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    dd4a5b2 View commit details
    Browse the repository at this point in the history

  45. Join the guard statements for isNewUI and `getBillingFormViewContr… 

    …oller`
    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0c01976 View commit details
    Browse the repository at this point in the history

  46. Fix Memory Leak

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5e74377 View commit details
    Browse the repository at this point in the history

  47. TODO: CountryCode

    @ehab-al-cko
    ehab-al-cko committed May 10, 2022
    Configuration menu
    Copy the full SHA
    61b42c0 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. //TODO: migrate to assets

    @ehab-al-cko
    ehab-al-cko committed May 11, 2022
    Configuration menu
    Copy the full SHA
    3b53468 View commit details
    Browse the repository at this point in the history

  2. revert to 3.3.3

    @ehab-al-cko
    ehab-al-cko committed May 11, 2022
    Configuration menu
    Copy the full SHA
    07a18fd View commit details
    Browse the repository at this point in the history

  3. Revert PhoneNumberKit to 3.3.0

    @ehab-al-cko
    ehab-al-cko committed May 11, 2022
    Configuration menu
    Copy the full SHA
    bad5997 View commit details
    Browse the repository at this point in the history

  4. Add required Fonts

    @ehab-al-cko
    ehab-al-cko committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1dedcc8 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. Update padding for header view

    @ehab-al-cko
    ehab-al-cko committed May 12, 2022
    Configuration menu
    Copy the full SHA
    a57c2d7 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Clean code

    @ehab-al-cko
    ehab-al-cko committed May 13, 2022
    Configuration menu
    Copy the full SHA
    b538fde View commit details
    Browse the repository at this point in the history

  2. Fix Carthage build error

    @ehab-al-cko
    ehab-al-cko committed May 13, 2022
    Configuration menu
    Copy the full SHA
    abd3e24 View commit details
    Browse the repository at this point in the history

  3. Add: A merchant can choose if that field is optional or mandatory to … 

    …be filled
    @ehab-al-cko
    ehab-al-cko committed May 13, 2022
    Configuration menu
    Copy the full SHA
    bbcdcba View commit details
    Browse the repository at this point in the history